Remove continue-on-error Windows jobs ci #313

mcbarton · 2024-08-03T19:27:16Z

The objective of this PR is to add to the ci a non wasm build of xeus-cpp which runs its various tests. This should allow debugging of the missing symbols needed to make Windows work (discussion here compiler-research/xeus-cpp#144).

codecov · 2024-08-03T20:12:14Z

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.29%. Comparing base (920347b) to head (0f4f348).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/Interpreter/Paths.cpp	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
+ Coverage   74.27%   74.29%   +0.01%     
==========================================
  Files           8        8              
  Lines        3188     3190       +2     
==========================================
+ Hits         2368     2370       +2     
  Misses        820      820

Files with missing lines	Coverage Δ
lib/Interpreter/Compatibility.h	`89.90% <100.00%> (+0.18%)`	⬆️
lib/Interpreter/CppInterOp.cpp	`79.83% <ø> (ø)`
lib/Interpreter/DynamicLibraryManager.cpp	`73.46% <100.00%> (ø)`
lib/Interpreter/Paths.cpp	`37.74% <0.00%> (ø)`

Files with missing lines	Coverage Δ
lib/Interpreter/Compatibility.h	`89.90% <100.00%> (+0.18%)`	⬆️
lib/Interpreter/CppInterOp.cpp	`79.83% <ø> (ø)`
lib/Interpreter/DynamicLibraryManager.cpp	`73.46% <100.00%> (ø)`
lib/Interpreter/Paths.cpp	`37.74% <0.00%> (ø)`

mcbarton · 2024-08-08T19:22:22Z

@vgvassilev looking at the output of the ci here https://github.com/compiler-research/CppInterOp/actions/runs/10288514553/job/28502994037 it appears that only a few symbols are left to be exported to get std::cout and std::cerr to work in xeus-cpp on Windows, but I can't work out where they need to be exported, since both CppInterOp and xeus-cpp are exporting the symbols it is complaining about. Any idea what these symbols need to be exported?

github-actions · 2024-08-21T12:08:08Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions

clang-tidy made some suggestions

lib/Interpreter/DynamicLibraryManager.cpp

github-actions

clang-tidy made some suggestions

lib/Interpreter/DynamicLibraryManager.cpp

github-actions

clang-tidy made some suggestions

lib/Interpreter/DynamicLibraryManager.cpp

github-actions · 2024-08-21T13:04:09Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions

clang-tidy made some suggestions

lib/Interpreter/Paths.cpp

github-actions · 2024-08-21T13:23:43Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-08-21T13:32:15Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions

clang-tidy made some suggestions

lib/Interpreter/CppInterOp.cpp

github-actions · 2024-08-21T16:03:58Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-08-21T18:15:57Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-08-21T18:49:04Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-08-21T19:11:36Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-08-21T19:33:51Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-08-22T08:20:39Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-08-22T08:59:40Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-08-22T09:08:59Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-08-22T10:10:52Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-10-25T20:16:34Z

clang-tidy review says "All clean, LGTM! 👍"

CMakeLists.txt

cmake/CppInterOp/CppInterOpConfig.cmake.in

CMakeLists.txt

cmake/modules/GoogleTest.cmake

lib/Interpreter/CppInterOp.cpp

lib/Interpreter/DynamicLibraryManager.cpp

unittests/CppInterOp/CUDATest.cpp

github-actions · 2024-10-26T12:35:56Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-10-26T13:23:44Z

clang-tidy review says "All clean, LGTM! 👍"

vgvassilev

Lgtm modulo the comment.

unittests/CppInterOp/VariableReflectionTest.cpp

mcbarton · 2024-10-26T15:15:55Z

@vgvassilev getenv_s is not being recognised on Unix systems. Any ideas why?

github-actions

clang-tidy made some suggestions

lib/Interpreter/DynamicLibraryManager.cpp

lib/Interpreter/Paths.cpp

Gnimuc · 2025-01-11T09:36:20Z

@vgvassilev getenv_s is not being recognised on Unix systems. Any ideas why?

looks like getenv_s is optional in the C11 standard.

X-ref: https://stackoverflow.com/questions/372980/do-you-use-the-tr-24731-safe-functions/373911#373911

mcbarton force-pushed the Add-non-wasm-build-xeus-cpp branch 3 times, most recently from aec490f to c879a57 Compare August 7, 2024 10:35

mcbarton force-pushed the Add-non-wasm-build-xeus-cpp branch 5 times, most recently from f640d31 to e507f53 Compare August 17, 2024 20:20

github-actions bot reviewed Aug 21, 2024

View reviewed changes

lib/Interpreter/DynamicLibraryManager.cpp Outdated Show resolved Hide resolved

mcbarton force-pushed the Add-non-wasm-build-xeus-cpp branch from 24ab8b9 to de94995 Compare August 21, 2024 12:33

github-actions bot reviewed Aug 21, 2024

View reviewed changes

lib/Interpreter/DynamicLibraryManager.cpp Outdated Show resolved Hide resolved

github-actions bot reviewed Aug 21, 2024

View reviewed changes

lib/Interpreter/DynamicLibraryManager.cpp Outdated Show resolved Hide resolved

lib/Interpreter/DynamicLibraryManager.cpp Outdated Show resolved Hide resolved

github-actions bot reviewed Aug 21, 2024

View reviewed changes

lib/Interpreter/Paths.cpp Outdated Show resolved Hide resolved

github-actions bot reviewed Aug 21, 2024

View reviewed changes

lib/Interpreter/CppInterOp.cpp Outdated Show resolved Hide resolved

lib/Interpreter/CppInterOp.cpp Outdated Show resolved Hide resolved

lib/Interpreter/CppInterOp.cpp Outdated Show resolved Hide resolved

mcbarton force-pushed the Add-non-wasm-build-xeus-cpp branch from 039bf03 to 8b248a3 Compare August 21, 2024 19:26

mcbarton force-pushed the Add-non-wasm-build-xeus-cpp branch 3 times, most recently from bfc0f56 to 14b0a6a Compare October 25, 2024 19:58

mcbarton changed the title ~~Get Windows jobs in ci to pass.~~ Remove continue-on-error Windows jobs ci Oct 25, 2024

mcbarton marked this pull request as ready for review October 25, 2024 20:32

vgvassilev reviewed Oct 26, 2024

View reviewed changes

mcbarton force-pushed the Add-non-wasm-build-xeus-cpp branch 2 times, most recently from a7093c3 to a256714 Compare October 26, 2024 13:02

mcbarton force-pushed the Add-non-wasm-build-xeus-cpp branch 4 times, most recently from 8400eb5 to 9b86ee2 Compare October 26, 2024 15:06

vgvassilev approved these changes Oct 26, 2024

View reviewed changes

unittests/CppInterOp/VariableReflectionTest.cpp Show resolved Hide resolved

github-actions bot reviewed Oct 26, 2024

View reviewed changes

mcbarton force-pushed the Add-non-wasm-build-xeus-cpp branch 5 times, most recently from 0f1a770 to da0902c Compare October 26, 2024 18:16

Remove continue on error Windows jobs ci

0f4f348

mcbarton force-pushed the Add-non-wasm-build-xeus-cpp branch from da0902c to 0f4f348 Compare October 26, 2024 18:17

mcbarton requested a review from vgvassilev October 26, 2024 18:54

vgvassilev merged commit c0a4dfe into compiler-research:main Oct 26, 2024
54 of 55 checks passed

mcbarton mentioned this pull request Oct 27, 2024

Re-enable win tests #206

Closed

mcbarton mentioned this pull request Dec 6, 2024

Disable the failing windows build #191

Closed

Remove continue-on-error Windows jobs ci #313

Remove continue-on-error Windows jobs ci #313

Uh oh!

Conversation

mcbarton commented Aug 3, 2024

Uh oh!

codecov bot commented Aug 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mcbarton commented Aug 8, 2024

Uh oh!

github-actions bot commented Aug 21, 2024

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 21, 2024

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Aug 21, 2024

Uh oh!

github-actions bot commented Aug 21, 2024

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 21, 2024

Uh oh!

github-actions bot commented Aug 21, 2024

Uh oh!

github-actions bot commented Aug 21, 2024

Uh oh!

github-actions bot commented Aug 21, 2024

Uh oh!

github-actions bot commented Aug 21, 2024

Uh oh!

github-actions bot commented Aug 22, 2024

Uh oh!

github-actions bot commented Aug 22, 2024

Uh oh!

github-actions bot commented Aug 22, 2024

Uh oh!

github-actions bot commented Aug 22, 2024

Uh oh!

github-actions bot commented Oct 25, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 26, 2024

Uh oh!

github-actions bot commented Oct 26, 2024

Uh oh!

vgvassilev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Aug 3, 2024 •

edited

Loading

Gnimuc commented Jan 11, 2025 •

edited

Loading